From 1ead42626e85476242f6410aee82fac89c551747 Mon Sep 17 00:00:00 2001 From: cktricky Date: Tue, 19 Sep 2017 11:21:08 -0400 Subject: [PATCH] I have moved the build_benefits_data invocation from the controller to the model using before_create. This has not affected behavior afaict. Tested by running rake db:drop db:setup and RAILSGOAT_MAINTAINER=yes rake (all tests passed). --- app/controllers/users_controller.rb | 1 - app/models/user.rb | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index d577d50..ac3613e 100755 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -8,7 +8,6 @@ class UsersController < ApplicationController def create user = User.new(user_params) - user.build_benefits_data if user.save session[:user_id] = user.user_id redirect_to home_dashboard_index_path diff --git a/app/models/user.rb b/app/models/user.rb index 38eeb2e..2ec814c 100755 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -21,6 +21,7 @@ class User < ApplicationRecord has_many :messages, :foreign_key => :receiver_id, :primary_key => :user_id, :dependent => :destroy has_many :pay, :foreign_key => :user_id, :primary_key => :user_id, :dependent => :destroy before_create { generate_token(:auth_token) } + before_create :build_benefits_data def build_benefits_data build_retirement(POPULATE_RETIREMENTS.shuffle.first)