From 284cd8811c80f0823ebf8abf2afa38bd99dfd443 Mon Sep 17 00:00:00 2001 From: Joseph Mastey Date: Tue, 5 Dec 2017 18:38:32 -0600 Subject: [PATCH] feat(rubocop): use rubocop-github --- .rubocop.yml | 8 +- Gemfile | 2 +- Gemfile.lock | 4 +- config/rubocop/default.yml | 314 ------------------------------------- config/rubocop/rails.yml | 55 ------- 5 files changed, 8 insertions(+), 375 deletions(-) delete mode 100644 config/rubocop/default.yml delete mode 100644 config/rubocop/rails.yml diff --git a/.rubocop.yml b/.rubocop.yml index 3d4dd33..6c1c91e 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,5 @@ - -inherit_from: - - ./config/rubocop/default.yml - - ./config/rubocop/rails.yml +inherit_gem: + rubocop-github: + - config/default.yml + - config/rails.yml diff --git a/Gemfile b/Gemfile index d2385c9..6b69e75 100644 --- a/Gemfile +++ b/Gemfile @@ -32,7 +32,7 @@ group :development, :mysql do gem 'travis-lint' gem 'better_errors' gem 'binding_of_caller' - gem 'rubocop' + gem "rubocop-github" end gem 'simplecov', :require => false, :group => :test diff --git a/Gemfile.lock b/Gemfile.lock index 0797bee..f0add55 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -267,6 +267,8 @@ GEM rainbow (>= 2.2.2, < 3.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.0, >= 1.0.1) + rubocop-github (0.6.0) + rubocop (~> 0.51) ruby-prof (0.16.2) ruby-progressbar (1.9.0) ruby_dep (1.5.0) @@ -358,7 +360,7 @@ DEPENDENCIES rb-fsevent responders rspec-rails - rubocop + rubocop-github ruby-prof sass-rails simplecov diff --git a/config/rubocop/default.yml b/config/rubocop/default.yml deleted file mode 100644 index 5b29afe..0000000 --- a/config/rubocop/default.yml +++ /dev/null @@ -1,314 +0,0 @@ -AllCops: - DisabledByDefault: true - -Bundler/DuplicatedGem: - Enabled: true - -Bundler/OrderedGems: - Enabled: true - -Lint/BlockAlignment: - Enabled: true - -Lint/CircularArgumentReference: - Enabled: true - -Lint/ConditionPosition: - Enabled: true - -Lint/Debugger: - Enabled: true - -Lint/DefEndAlignment: - Enabled: true - -Lint/DeprecatedClassMethods: - Enabled: true - -Lint/DuplicateMethods: - Enabled: true - -Lint/DuplicatedKey: - Enabled: true - -Lint/EachWithObjectArgument: - Enabled: true - -Lint/ElseLayout: - Enabled: true - -Lint/EmptyEnsure: - Enabled: true - -Lint/EndInMethod: - Enabled: true - -Lint/EmptyInterpolation: - Enabled: true - -Lint/EndAlignment: - Enabled: false - -Lint/EnsureReturn: - Enabled: true - -Lint/FloatOutOfRange: - Enabled: true - -Lint/FormatParameterMismatch: - Enabled: true - -Style/HashSyntax: - Enabled: true - EnforcedStyle: ruby19 - -Lint/LiteralInInterpolation: - Enabled: true - -Lint/Loop: - Enabled: true - -Lint/NextWithoutAccumulator: - Enabled: true - -Lint/RandOne: - Enabled: true - -Lint/RequireParentheses: - Enabled: true - -Lint/RescueException: - Enabled: true - -Lint/StringConversionInInterpolation: - Enabled: true - -Lint/UnderscorePrefixedVariableName: - Enabled: true - -Lint/UnneededDisable: - Enabled: true - -Lint/UnneededSplatExpansion: - Enabled: true - -Lint/UnreachableCode: - Enabled: true - -Lint/UselessComparison: - Enabled: true - -Lint/UselessSetterCall: - Enabled: true - -Lint/Void: - Enabled: true - -Metrics/AbcSize: - Enabled: false - -Metrics/BlockLength: - Enabled: false - -Metrics/BlockNesting: - Enabled: false - -Metrics/ClassLength: - Enabled: false - -Metrics/CyclomaticComplexity: - Enabled: false - -Metrics/LineLength: - Enabled: false - -Metrics/MethodLength: - Enabled: false - -Metrics/ModuleLength: - Enabled: false - -Metrics/ParameterLists: - Enabled: false - -Metrics/PerceivedComplexity: - Enabled: false - -Performance/CaseWhenSplat: - Enabled: false - -Performance/Count: - Enabled: true - -Performance/Detect: - Enabled: true - -Performance/DoubleStartEndWith: - Enabled: true - -Performance/EndWith: - Enabled: true - -Performance/FlatMap: - Enabled: true - -Performance/HashEachMethods: - Enabled: true - -Performance/LstripRstrip: - Enabled: true - -Performance/RangeInclude: - Enabled: false - -Performance/RedundantMatch: - Enabled: false - -Performance/RedundantMerge: - Enabled: true - MaxKeyValuePairs: 1 - -Performance/RedundantSortBy: - Enabled: true - -Performance/ReverseEach: - Enabled: true - -Performance/Sample: - Enabled: true - -Performance/Size: - Enabled: true - -Performance/StartWith: - Enabled: true - -Security/Eval: - Enabled: true - -Style/ArrayJoin: - Enabled: true - -Style/AsciiIdentifiers: - Enabled: true - -Style/BeginBlock: - Enabled: true - -Style/BlockComments: - Enabled: true - -Layout/BlockEndNewline: - Enabled: true - -Style/CaseEquality: - Enabled: true - -Style/CharacterLiteral: - Enabled: true - -Style/ClassAndModuleCamelCase: - Enabled: true - -Style/ClassMethods: - Enabled: true - -Style/Copyright: - Enabled: false - -Style/DefWithParentheses: - Enabled: true - -Style/EndBlock: - Enabled: true - -Layout/EndOfLine: - Enabled: true - -Style/FileName: - Enabled: true - -Style/FlipFlop: - Enabled: true - -Style/For: - Enabled: true - -Style/FrozenStringLiteralComment: - Enabled: true - -Layout/InitialIndentation: - Enabled: true - -Style/LambdaCall: - Enabled: true - -Style/MethodCallWithoutArgsParentheses: - Enabled: true - -Style/MethodDefParentheses: - Enabled: true - -Style/MethodName: - Enabled: true - -Style/MultilineIfThen: - Enabled: true - -Style/NilComparison: - Enabled: true - -Style/Not: - Enabled: true - -Style/OneLineConditional: - Enabled: true - -Layout/SpaceAfterMethodName: - Enabled: true - -Layout/SpaceAfterColon: - Enabled: true - -Layout/SpaceAfterComma: - Enabled: true - -Layout/SpaceAfterNot: - Enabled: true - -Layout/SpaceAfterSemicolon: - Enabled: true - -Layout/SpaceAroundBlockParameters: - Enabled: true - -Layout/SpaceAroundEqualsInParameterDefault: - Enabled: true - -Layout/SpaceInsideArrayPercentLiteral: - Enabled: true - -Layout/SpaceInsideBrackets: - Enabled: true - -Layout/SpaceInsideParens: - Enabled: true - -Layout/SpaceInsideRangeLiteral: - Enabled: true - -Style/StabbyLambdaParentheses: - Enabled: true - -Style/StringLiterals: - Enabled: true - EnforcedStyle: double_quotes - -Layout/Tab: - Enabled: true - -Layout/TrailingBlankLines: - Enabled: true - -Layout/TrailingWhitespace: - Enabled: true \ No newline at end of file diff --git a/config/rubocop/rails.yml b/config/rubocop/rails.yml deleted file mode 100644 index 3708fcc..0000000 --- a/config/rubocop/rails.yml +++ /dev/null @@ -1,55 +0,0 @@ -Rails: - Enabled: true - -Rails/FindEach: - Enabled: false - -Rails/OutputSafety: - Enabled: true - -Rails/PluralizationGrammar: - Enabled: true - -Rails/RequestReferer: - Enabled: true - EnforcedStyle: referrer - -Rails/ScopeArgs: - Enabled: true - -Rails/UniqBeforePluck: - Enabled: true - -# Exclude Rails ERB files from incompatible cops - -Lint/BlockAlignment: - Exclude: - - 'app/views/**/*.erb' - -Style/For: - Exclude: - - 'app/views/**/*.erb' - -Style/OneLineConditional: - Exclude: - - 'app/views/**/*.erb' - -Style/Semicolon: - Exclude: - - 'app/views/**/*.erb' - -Layout/SpaceInsideParens: - Exclude: - - 'app/views/**/*.erb' - -Style/StringLiterals: - Exclude: - - 'app/views/**/*.erb' - -Layout/TrailingBlankLines: - Exclude: - - 'app/views/**/*.erb' - -Layout/TrailingWhitespace: - Exclude: - - 'app/views/**/*.erb' \ No newline at end of file