- Within the Gemfile the following gem versions are set. These versions of Rails and Rack are both vulnerable to multiple attacks. -
-
- <%= %q{
- gem 'rails', '3.2.11'
- gem 'rack', '1.4.3'
- } %>
-
+ Within the file app/assets/javascripts/jquery.snippet.js:
+
+ <%= %{
+// snippet new window popup function
+function snippetPopup(content) \{
+ top.consoleRef=window.open('','myconsole',
+ 'width=600,height=300'
+ +',left=50,top=50'
+ +',menubar=0'
+ +',toolbar=0'
+ +',location=0'
+ +',status=0'
+ +',scrollbars=1'
+ +',resizable=1');
+ top.consoleRef.document.writeln(
+ 'Snippet :: Code View :: '+}%><span style="background-color:yellow">location.href</span><%= %{+' '
+ +''
+ +''+content+'
'
+ +''
+ );
+ top.consoleRef.document.close();
+\}}%>
+ + We can see that the location.href DOM property is used to dynamically generate a title for the text box pop-up. This value is string concatenated directly from the DOM without first performing some escaping routine or HTML encoding. +
- To fix this issue, simply update your gems after unpinning the gem versions. You should always run the most up to date version possible and run Bundler-Audit Regularly. -
+Using Components with Known Vulnerabilities (DOM XSS) - ATTACK
++ In order to demonstrate that you can indeed perform DOM XSS through this coding error, we will use a simple alert box. This does not appear to work in Chrome, Safari, or Firefox as they first URL encoded the script portion of the url before rendering which complicates browser interpretation. IE on the other hand, true to form, is totally vulnerable. The following example assumes you are running Railsgoat on localhost, port 3000. If this is the case, open IE, paste the URL (below) into IE. +
++<%= "http://localhost:3000/tutorials/injection#" %> ++
+ The portion after the pound (#) symbol will close off the title and head portions of the HTML and then allow for properly generated JavaScript to be rendered and executed. After browsing to this URL, navigate to the tutorial where code snippets are shown and click on the "pop-up" link that appears after hovering over the code snippet. This should be all that is required to demonstrate DOM-XSS. +
+Using Components with Known Vulnerabilities (DOM XSS) - SOLUTION
++ Use the hoganEscape() function defined in application.js to solve this problem. For instance: +
+
+<%=%{'Snippet :: Code View :: '+}%><span style="background-color:yellow">hoganEscape(location.href)</span> <%=%{+' ' }%>
+