Merge pull request #482 from OWASP/feature/improve-file-upload-ux

Fix file upload flash messages and add GET redirect

app/controllers/benefit_forms_controller.rb

@@ -16,6 +16,11 @@ class BenefitFormsController < ApplicationController
    end
   end
 
+  def redirect_to_benefit_forms
+    flash[:info] = "Please use the upload form below to upload files"
+    redirect_to user_benefit_forms_path(user_id: current_user.id)
+  end
+
   def upload
     file = params[:benefits][:upload]
 

app/views/layouts/shared/_messages.html.erb

@@ -28,7 +28,7 @@
     end
   %>
 
-  <div class="alert <%= alert_class %> alert-dismissible fade show d-flex align-items-center" role="alert">
+  <div class="alert <%= alert_class %> alert-dismissible show d-flex align-items-center" role="alert">
     <i class="bi <%= icon_class %> me-2"></i>
     <div class="flex-grow-1">
       <%= msg %>

config/routes.rb

@@ -34,6 +34,7 @@ Railsgoat::Application.routes.draw do
   end
 
   get "download" => "benefit_forms#download"
+  get "upload" => "benefit_forms#redirect_to_benefit_forms"
   post "upload" => "benefit_forms#upload"
 
   resources :tutorials do