assign_user_id and UserFixture password fixes.

When the database is empty, which can happen in the test database and in
the dev database if the seeds.rb aren't applied, the assign_user_id
method would not assign an id and the newer before_filter block to
generate_token would fail.

UserFixture had a password on it that wouldn't pass the new validation
rules once that vulnerability is patched.
This commit is contained in:
chrismo
2015-01-06 11:47:05 -06:00
committed by cktricky
parent c39b0c35fd
commit 73e8ab972b
2 changed files with 8 additions and 4 deletions
+5 -1
View File
@@ -77,7 +77,11 @@ class User < ActiveRecord::Base
def assign_user_id def assign_user_id
unless @skip_user_id_assign.present? || self.user_id.present? unless @skip_user_id_assign.present? || self.user_id.present?
user = User.order("user_id").last user = User.order("user_id").last
uid = user.user_id.to_i + 1 if user && user.user_id && !(User.exists?(:user_id => "#{user.user_id.to_i + 1}")) uid = if user && user.user_id && !(User.exists?(:user_id => "#{user.user_id.to_i + 1}"))
user.user_id.to_i + 1
else
1
end
self.user_id = uid.to_s if uid self.user_id = uid.to_s if uid
end end
end end
+3 -3
View File
@@ -5,14 +5,14 @@ class UserFixture
end end
def self.normal_user def self.normal_user
password = 'aoeuaoeu' password = 'thi$ 1s cOmplExEr'
user = User.new(:first_name => 'Joe', :last_name => 'Schmoe', user = User.new(:first_name => 'Joe', :last_name => 'Schmoe',
:email => 'joe@schmoe.com', :password => password, :password_confirmation => password) :email => 'joe@schmoe.com', :password => password, :password_confirmation => password)
def user.clear_password def user.clear_password
'aoeuaoeu' 'thi$ 1s cOmplExEr'
end end
user.build_benefits_data user.build_benefits_data
user.save! user.save!
user user
end end
end end