From 7acc17aea3d8322233f20106f0cbc44780cf95ec Mon Sep 17 00:00:00 2001 From: cktricky Date: Thu, 22 May 2014 10:56:29 -0600 Subject: [PATCH] everything checks out re: unit tests. Additionally, this closes issue #112 (seriously, are we up to 112 issues already?) --- .../_insecure_components_first.html.erb | 2 +- .../_insecure_components_second.html.erb | 109 ++++++++++++++++++ .../tutorials/insecure_components.html.erb | 5 + 3 files changed, 115 insertions(+), 1 deletion(-) create mode 100644 app/views/layouts/tutorial/insecure_components/_insecure_components_second.html.erb diff --git a/app/views/layouts/tutorial/insecure_components/_insecure_components_first.html.erb b/app/views/layouts/tutorial/insecure_components/_insecure_components_first.html.erb index b5192d5..208412e 100644 --- a/app/views/layouts/tutorial/insecure_components/_insecure_components_first.html.erb +++ b/app/views/layouts/tutorial/insecure_components/_insecure_components_first.html.erb @@ -1,7 +1,7 @@
- A9 - Using Components with Known Vulnerabilities + A9 - Using Components with Known Vulnerabilities (Rack / Rails)
diff --git a/app/views/layouts/tutorial/insecure_components/_insecure_components_second.html.erb b/app/views/layouts/tutorial/insecure_components/_insecure_components_second.html.erb new file mode 100644 index 0000000..0c424c4 --- /dev/null +++ b/app/views/layouts/tutorial/insecure_components/_insecure_components_second.html.erb @@ -0,0 +1,109 @@ +
+
+
+ A9 - Using Components with Known Vulnerabilities (DOM XSS / JQuery Snippet) +
+
+
+
+
+
+ + + + Description + +
+
+
+ JQuery Snippet contains at least one DOM-Based XSS vulnerability that can be confirmed in IE11. Unknowingly, the Railsgoat development team used this library. Credit for vulnerability discovery as well as submission to <%= link_to "@raesene", "http://github.com/raesene", {:style => "color: rgb(181, 121, 158)", :target => "_blank"}%>. This was unintentional but goes to show how easily vulnerabilities can creep in when using third-party libraries. +
+
+
+
+
+ + + + Bug + +
+
+
+

+ Within the file app/assets/javascripts/jquery.snippet.js: +

+ 
+				<%= %{
+// snippet new window popup function
+function snippetPopup(content) \{
+	 top.consoleRef=window.open('','myconsole',
+	  'width=600,height=300'
+	   +',left=50,top=50'
+	   +',menubar=0'
+	   +',toolbar=0'
+	   +',location=0'
+	   +',status=0'
+	   +',scrollbars=1'
+	   +',resizable=1');
+	 top.consoleRef.document.writeln(
+	  'Snippet :: Code View :: '+}%><span style="background-color:yellow">location.href</span><%= %{+''
+	   +''
+	   +'
'+content+'
'
+	   +''
+	 );
+	 top.consoleRef.document.close();
+\}}%>
+

+ We can see that the location.href DOM property is used to dynamically generate a title for the text box pop-up. This value is string concatenated directly from the DOM without first performing some escaping routine or HTML encoding. +

+
+
+
+
+
+ + + + Solution + +
+
+
+

Using Components with Known Vulnerabilities (DOM XSS) - ATTACK

+

+ In order to demonstrate that you can indeed perform DOM XSS through this coding error, we will use a simple alert box. This does not appear to work in Chrome, Safari, or Firefox as they first URL encoded the script portion of the url before rendering which complicates browser interpretation. IE on the other hand, true to form, is totally vulnerable. The following example assumes you are running Railsgoat on localhost, port 3000. If this is the case, open IE, paste the URL (below) into IE. +

+ 
+<%= "http://localhost:3000/tutorials/injection#" %>
+
+

+ The portion after the pound (#) symbol will close off the title and head portions of the HTML and then allow for properly generated JavaScript to be rendered and executed. After browsing to this URL, navigate to the tutorial where code snippets are shown and click on the "pop-up" link that appears after hovering over the code snippet. This should be all that is required to demonstrate DOM-XSS. +

+

Using Components with Known Vulnerabilities (DOM XSS) - SOLUTION

+

+ Use the hoganEscape() function defined in application.js to solve this problem. For instance: +

+ 
+<%=%{'Snippet :: Code View :: '+}%><span style="background-color:yellow">hoganEscape(location.href)</span> <%=%{+'' }%>
+
+
+
+
+
+
+ + + + Hint + +
+
+
+ Review the JQuery Code Snippet for any content that might be mirrored or reflected back and that is under our control. +
+
+
+
+
+
\ No newline at end of file diff --git a/app/views/tutorials/insecure_components.html.erb b/app/views/tutorials/insecure_components.html.erb index 271f7a9..66d9863 100644 --- a/app/views/tutorials/insecure_components.html.erb +++ b/app/views/tutorials/insecure_components.html.erb @@ -5,6 +5,11 @@ <%= render :partial => "layouts/tutorial/insecure_components/insecure_components_first" %>
+
+
+ <%= render :partial => "layouts/tutorial/insecure_components/insecure_components_second" %> +
+