Ken Johnson
5d698c8003
Updated vulnerability specs to use `skip` instead of `pending` to align with RSpec 3+ semantics where pending means "expected to fail." Background: In RSpec 2, `pending` would skip tests. In RSpec 3+, `pending` marks a test as expected to fail, and if it passes, that's an error. This was causing issues in maintainer mode where passing tests were incorrectly flagged as failures. Changes: - Replaced `pending unless verifying_fixed?` with `skip unless verifying_fixed?` in 11 vulnerability spec files: - broken_auth_spec.rb - command_injection_spec.rb - csrf_spec.rb - insecure_dor_spec.rb - mass_assignment_spec.rb - password_complexity_spec.rb - sensitive_data_exposure.rb - sql_injection_spec.rb - unvalidated_redirects_spec.rb - url_access_spec.rb - xss_spec.rb Impact: - Maintainer mode: Tests are properly skipped (no false failures) - Training mode: Tests run and demonstrate vulnerabilities as before - All tests pass with 0 failures in maintainer mode Reference: https://rspec.info/blog/2014/05/notable-changes-in-rspec-3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
48 lines
1.5 KiB
Ruby
48 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
require "spec_helper"
|
|
require "tmpdir"
|
|
|
|
feature "csrf" do
|
|
let(:normal_user) { UserFixture.normal_user }
|
|
|
|
before(:each) do
|
|
UserFixture.reset_all_users
|
|
skip unless verifying_fixed?
|
|
end
|
|
|
|
scenario "attack\nTutorial: https://github.com/OWASP/railsgoat/wiki/R4-A8-CSRF", js: true do
|
|
visit "/"
|
|
# TODO: is there a way to get this without visiting root first?
|
|
base_url = current_url
|
|
|
|
login(normal_user)
|
|
|
|
Dir.mktmpdir do |dir|
|
|
hackety_file = File.join(dir, "form.on.bad.guy.site.html")
|
|
post_url = "#{base_url}schedule.json"
|
|
File.open(hackety_file, "w") do |f|
|
|
f.print <<-HTML
|
|
<html>
|
|
<body>
|
|
<form id='submit_me' action="#{post_url}" method="POST">
|
|
<input type="hidden" name="schedule[event_name]" value="Bad Guy" />
|
|
<input type="hidden" name="schedule[event_type]" value="pto" />
|
|
<input type="hidden" name="schedule[event_desc]" value="Fun Fun" />
|
|
<input type="hidden" name="date_range1" value="06/08/2013 - 06/09/2013" />
|
|
<input type="submit" value="Submit request" />
|
|
</form>
|
|
</body>
|
|
</html>
|
|
HTML
|
|
end
|
|
|
|
page.driver.visit "file://#{hackety_file}"
|
|
within("#submit_me") do
|
|
click_on "Submit request"
|
|
end
|
|
end
|
|
|
|
expect(normal_user.reload.paid_time_off.schedule.last.event_name).not_to eq("Bad Guy")
|
|
end
|
|
end
|