team-alpha/railsgoat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

I have moved the build_benefits_data invocation from the controller to the model using before_create. This has not affected behavior afaict. Tested by running rake db:drop db:setup and RAILSGOAT_MAINTAINER=yes rake (all tests passed).

Browse Source
This commit is contained in:
cktricky
2017-09-19 11:21:08 -04:00
parent 4d17b3b2b0
commit 1ead42626e
2 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/controllers/users_controller.rb
-1
View File
@@ -8,7 +8,6 @@ class UsersController < ApplicationController
def create def create
user = User.new(user_params) user = User.new(user_params)
user.build_benefits_data
if user.save if user.save
session[:user_id] = user.user_id session[:user_id] = user.user_id
redirect_to home_dashboard_index_path redirect_to home_dashboard_index_path
app/models/user.rb
+1
View File
@@ -21,6 +21,7 @@ class User < ApplicationRecord
has_many :messages, :foreign_key => :receiver_id, :primary_key => :user_id, :dependent => :destroy has_many :messages, :foreign_key => :receiver_id, :primary_key => :user_id, :dependent => :destroy
has_many :pay, :foreign_key => :user_id, :primary_key => :user_id, :dependent => :destroy has_many :pay, :foreign_key => :user_id, :primary_key => :user_id, :dependent => :destroy
before_create { generate_token(:auth_token) } before_create { generate_token(:auth_token) }
before_create :build_benefits_data
def build_benefits_data def build_benefits_data
build_retirement(POPULATE_RETIREMENTS.shuffle.first) build_retirement(POPULATE_RETIREMENTS.shuffle.first)