Ken Johnson
5d698c8003
Updated vulnerability specs to use `skip` instead of `pending` to align with RSpec 3+ semantics where pending means "expected to fail." Background: In RSpec 2, `pending` would skip tests. In RSpec 3+, `pending` marks a test as expected to fail, and if it passes, that's an error. This was causing issues in maintainer mode where passing tests were incorrectly flagged as failures. Changes: - Replaced `pending unless verifying_fixed?` with `skip unless verifying_fixed?` in 11 vulnerability spec files: - broken_auth_spec.rb - command_injection_spec.rb - csrf_spec.rb - insecure_dor_spec.rb - mass_assignment_spec.rb - password_complexity_spec.rb - sensitive_data_exposure.rb - sql_injection_spec.rb - unvalidated_redirects_spec.rb - url_access_spec.rb - xss_spec.rb Impact: - Maintainer mode: Tests are properly skipped (no false failures) - Training mode: Tests run and demonstrate vulnerabilities as before - All tests pass with 0 failures in maintainer mode Reference: https://rspec.info/blog/2014/05/notable-changes-in-rspec-3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
39 lines
1.1 KiB
Ruby
39 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
require "spec_helper"
|
|
|
|
feature "mass assignment" do
|
|
let(:normal_user) { UserFixture.normal_user }
|
|
|
|
before do
|
|
UserFixture.reset_all_users
|
|
skip unless verifying_fixed?
|
|
end
|
|
|
|
scenario "attack one" do
|
|
expect(normal_user.admin).to be_falsey
|
|
login(normal_user)
|
|
|
|
params = { user: { admin: "t",
|
|
id: normal_user.id,
|
|
password: normal_user.clear_password,
|
|
password_confirmation: normal_user.clear_password }}
|
|
|
|
page.driver.put "/users/#{normal_user.id}.json", params
|
|
|
|
expect(normal_user.reload.admin).to be_falsy
|
|
end
|
|
|
|
scenario "attack two, Tutorial: https://github.com/OWASP/railsgoat/wiki/R4-Extras-Mass-Assignment-Admin-Role" do
|
|
params = { user: { admin: "t",
|
|
email: "hackety@h4x0rs.c0m",
|
|
first_name: "hackety",
|
|
last_name: "hax",
|
|
password: "foobarewe",
|
|
password_confirmation: "foobarewe" }}
|
|
|
|
page.driver.post "/users", params
|
|
|
|
expect(User.find_by(email: "hackety@h4x0rs.c0m").admin).to be_falsy
|
|
end
|
|
end
|