Ken Johnson
5d698c8003
Updated vulnerability specs to use `skip` instead of `pending` to align with RSpec 3+ semantics where pending means "expected to fail." Background: In RSpec 2, `pending` would skip tests. In RSpec 3+, `pending` marks a test as expected to fail, and if it passes, that's an error. This was causing issues in maintainer mode where passing tests were incorrectly flagged as failures. Changes: - Replaced `pending unless verifying_fixed?` with `skip unless verifying_fixed?` in 11 vulnerability spec files: - broken_auth_spec.rb - command_injection_spec.rb - csrf_spec.rb - insecure_dor_spec.rb - mass_assignment_spec.rb - password_complexity_spec.rb - sensitive_data_exposure.rb - sql_injection_spec.rb - unvalidated_redirects_spec.rb - url_access_spec.rb - xss_spec.rb Impact: - Maintainer mode: Tests are properly skipped (no false failures) - Training mode: Tests run and demonstrate vulnerabilities as before - All tests pass with 0 failures in maintainer mode Reference: https://rspec.info/blog/2014/05/notable-changes-in-rspec-3 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
35 lines
1.0 KiB
Ruby
35 lines
1.0 KiB
Ruby
# frozen_string_literal: true
|
|
require "spec_helper"
|
|
|
|
feature "insecure direct object reference" do
|
|
let(:normal_user) { UserFixture.normal_user }
|
|
let(:another_user) { User.find_by(id: 2) }
|
|
|
|
before do
|
|
UserFixture.reset_all_users
|
|
skip unless verifying_fixed?
|
|
end
|
|
|
|
scenario "attack one" do
|
|
login(normal_user)
|
|
|
|
visit "/users/#{normal_user.id}/benefit_forms"
|
|
download_url = first(".widget-body a")[:href]
|
|
visit download_url.sub(/name=(.*?)&/, "name=config/database.yml&")
|
|
|
|
expect(page.status_code).not_to eq(200)
|
|
expect(page.response_headers["Content-Disposition"].to_a).not_to include("database.yml")
|
|
end
|
|
|
|
scenario "attack two\nTutorial: https://github.com/OWASP/railsgoat/wiki/A4-Insecure-Direct-Object-Reference" do
|
|
login(normal_user)
|
|
|
|
expect(normal_user.id).not_to eq(another_user.id)
|
|
|
|
visit "/users/#{another_user.id}/work_info"
|
|
|
|
expect(first("td").text).not_to include(another_user.full_name)
|
|
expect(first("td").text).to include(normal_user.full_name)
|
|
end
|
|
end
|